Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add svgeez addon #445

Merged
merged 21 commits into from
Jul 26, 2023
Merged

Add svgeez addon #445

merged 21 commits into from
Jul 26, 2023

Conversation

mosharaf13
Copy link
Contributor

@mosharaf13 mosharaf13 commented Jul 13, 2023 •
edited
Loading

close #425

What happened 👀

  • Add svgeez as installable add-on while this template is being installed

Insight 📝

  • Adds svgeez as a gem in Gemfile

Proof Of Work 📹

Screen Shot 2023-07-13 at 5 31 47 PM
Screen Shot 2023-07-13 at 5 33 04 PM

@mosharaf13 mosharaf13 self-assigned this Jul 13, 2023
@andyduong1920
Copy link
Member

Sorry @mosharaf13 I updated the original issue, which we are using https://github.com/jgarber623/svgeez gem, you can have a look for that on

@mosharaf13 mosharaf13 changed the title Add svg-sprite addon Add svgeez addon Jul 13, 2023
@mosharaf13
Copy link
Contributor Author

Sorry @mosharaf13 I updated the original issue, which we are using https://github.com/jgarber623/svgeez gem, you can have a look for that on

Hi @andyduong1920,

I have replaced svg-sprite with svgeez and updated the PR

malparty
malparty approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, could you have a look please? 🙏

@andyduong1920
Copy link
Member

Hi @mosharaf13 could you also copy the following files in this addon as well 🙏

@andyduong1920
Copy link
Member

Also to finalize the feature, we will need the inline_svg gem as well could you help to add that Gem too 🙏 https://github.com/nimblehq/cx-web/blob/1d9e3290b886d75215786189b38126e74a523ae1/Gemfile#L26

olivierobert
olivierobert approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@olivierobert olivierobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor code style issue

.template/addons/svgeez/.github/wiki/template.rb Outdated Show resolved Hide resolved
tyrro
tyrro suggested changes Jul 20, 2023
View reviewed changes
.template/addons/svgeez/bin/svg-sprite Outdated Show resolved Hide resolved
.template/addons/svgeez/Gemfile.rb Show resolved Hide resolved
tyrro
tyrro suggested changes Jul 21, 2023
View reviewed changes
.template/addons/svgeez/.github/wiki/template.rb Outdated Show resolved Hide resolved
.template/addons/svgeez/.github/wiki/template.rb Outdated Show resolved Hide resolved
.template/addons/svgeez/Gemfile.rb Show resolved Hide resolved
@malparty malparty requested a review from tyrro July 25, 2023 01:48
@malparty malparty added this pull request to the merge queue Jul 26, 2023
Merged via the queue into develop with commit 6c8da12 Jul 26, 2023
5 checks passed
@malparty malparty deleted the feature/gh425-add-svg-sprite-addon branch July 26, 2023 08:13
@malparty malparty added this to the 5.7.0 milestone Jul 26, 2023
@malparty malparty mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malparty malparty malparty approved these changes

@olivierobert olivierobert olivierobert approved these changes

@andyduong1920 andyduong1920 andyduong1920 approved these changes

@tyrro tyrro tyrro approved these changes

@rosle rosle Awaiting requested review from rosle

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

@sanG-github sanG-github Awaiting requested review from sanG-github sanG-github is a code owner

Assignees

@mosharaf13 mosharaf13

Labels
type : feature
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

Add svgeez addon
5 participants
@mosharaf13 @andyduong1920 @olivierobert @tyrro @malparty